review-bot
  • Joined on 2026-04-03
review-bot commented on pull request johba/harb#11 2026-04-06 00:02:36 +00:00
chore: gardener housekeeping 2026-04-06

AI Review

Summary\n\nAutomated gardener housekeeping — advances the last-reviewed watermark in all 9 AGENTS.md files from…

review-bot approved johba/harb#11 2026-04-06 00:02:36 +00:00
chore: gardener housekeeping 2026-04-06

AI Review: APPROVE — Routine watermark advancement; all 9 AGENTS.md files correctly updated to baa501f (the current HEAD merge commit)

review-bot approved johba/harb#10 2026-04-05 18:12:55 +00:00
fix: match Position History background to Active Positions (#9)

AI Review: APPROVE — One-line CSS fix correctly aligns CollapseHistory background with CollapseActive; no logic, security, or correctness concerns.

review-bot commented on pull request johba/harb#10 2026-04-05 18:12:54 +00:00
fix: match Position History background to Active Positions (#9)

AI Review

Summary

This is a minimal CSS fix. The change adds background-color: #07111B to .f-collapse-history in `CollapseHi…

review-bot approved johba/harb#10 2026-04-05 18:12:31 +00:00
fix: match Position History background to Active Positions (#9)

AI Review: APPROVE — One-line CSS fix applies the correct background color to CollapseHistory, matching CollapseActive exactly.

review-bot commented on pull request johba/harb#10 2026-04-05 18:12:30 +00:00
fix: match Position History background to Active Positions (#9)

AI Review

Summary\n\nAdds background-color: #07111B to .f-collapse-history in CollapseHistory.vue, bringing it in line…

review-bot commented on pull request johba/harb#8 2026-04-05 18:07:52 +00:00
chore: gardener housekeeping 2026-04-05

AI Review

Summary

Docs-only gardener run: watermark bumps, env var documentation, Docker/LXD notes, viem v2 slot0 pattern, and…

review-bot approved johba/harb#8 2026-04-05 18:07:52 +00:00
chore: gardener housekeeping 2026-04-05

AI Review: APPROVE — Documentation-only housekeeping: all factual claims verified against actual code

review-bot approved johba/harb#6 2026-04-05 17:27:15 +00:00
fix: fix: protocol activity statistics stay zero — ponder watches wrong contract addresses (#4)

AI Re-review (round 3): APPROVE — Previous finding fixed: POOL_ADDRESS initialized before conditional block

review-bot approved johba/harb#6 2026-04-05 17:27:15 +00:00
fix: fix: protocol activity statistics stay zero — ponder watches wrong contract addresses (#4)

AI Re-review (round 3): APPROVE — Previous finding fixed: POOL_ADDRESS initialised before conditional block

review-bot commented on pull request johba/harb#6 2026-04-05 17:27:14 +00:00
fix: fix: protocol activity statistics stay zero — ponder watches wrong contract addresses (#4)

AI Re-review (round 3)

Previous Findings

  • Unbound variable crash scripts/bootstrap-common.sh:106 — FIXED: `POOL_ADDRESS…
review-bot commented on pull request johba/harb#6 2026-04-05 17:27:14 +00:00
fix: fix: protocol activity statistics stay zero — ponder watches wrong contract addresses (#4)

AI Re-review (round 3)

Previous Findings

  • Unbound POOL_ADDRESS under set -u (scripts/bootstrap-common.sh:107) →…
review-bot suggested changes for johba/harb#6 2026-04-05 17:23:59 +00:00
fix: fix: protocol activity statistics stay zero — ponder watches wrong contract addresses (#4)

AI Review: REQUEST_CHANGES — POOL_ADDRESS unbound variable in bootstrap-common.sh will crash bootstrap under set -u when factory lookup fails

review-bot commented on pull request johba/harb#6 2026-04-05 17:23:58 +00:00
fix: fix: protocol activity statistics stay zero — ponder watches wrong contract addresses (#4)

AI Review

Summary

This PR correctly identifies and fixes the root cause of zero protocol activity statistics: ponder was not…

review-bot suggested changes for johba/harb#6 2026-04-05 17:22:57 +00:00
fix: fix: protocol activity statistics stay zero — ponder watches wrong contract addresses (#4)

AI Review: REQUEST_CHANGES — POOL_ADDRESS unbound variable will abort bootstrap when factory call returns empty

review-bot commented on pull request johba/harb#6 2026-04-05 17:22:56 +00:00
fix: fix: protocol activity statistics stay zero — ponder watches wrong contract addresses (#4)

AI Review

Summary

This PR fixes protocol activity stats staying zero by making ponder watch the correct contract addresses. It…

review-bot suggested changes for johba/harb#3 2026-04-05 16:54:08 +00:00
fix: parse slot0 response as array — viem v2 compat (#2)

AI Re-review (round 3): REQUEST_CHANGES — Incremental commits regressed from the approved version: dropped bigint coercion safety and removed the explanatory comment

review-bot commented on pull request johba/harb#3 2026-04-05 16:54:07 +00:00
fix: parse slot0 response as array — viem v2 compat (#2)

AI Re-review (round 3)

Previous Findings\n\nNo findings in the previous review — it was an APPROVE at 0eb1816. The author…

review-bot commented on pull request johba/harb#3 2026-04-05 16:47:51 +00:00
fix: parse slot0 response as array — viem v2 compat (#2)

AI Review

Summary\n\nSmall, focused fix for viem v2's breaking change: readContract now returns multi-output calls as plain…

review-bot approved johba/harb#3 2026-04-05 16:47:51 +00:00
fix: parse slot0 response as array — viem v2 compat (#2)

AI Review: APPROVE — Correct array-index fix for viem v2 tuple return; fallback preserves forward compat