harb/onchain/VWAP_TEST_GAPS.md

VWAP Test Gaps Analysis - Post Dormant Whale Fix

Executive Summary

With the dormant whale protection implementation, comprehensive VWAPTracker test suite, and anti-arbitrage strategy validation, the most critical security gaps have been addressed. Remaining gaps are lower-priority LiquidityManager integration tests.

Context: Anti-Arbitrage Strategy

Trade-Recenter-Reverse Attack: Trader profits by exploiting predictable rebalancing through: large trade → trigger recenter() → reverse trade at new configuration.

Protection: Asymmetric slippage profile where ANCHOR (shallow liquidity, high slippage) forces attackers through expensive slippage twice, while FLOOR/DISCOVERY (deep liquidity) provide edge protection.

Key Architectural Principle: Only FLOOR uses VWAP (historical memory), while ANCHOR/DISCOVERY use current tick (immediate response).

---

VWAPTracker Tests - COMPREHENSIVE ✅

Core VWAP Logic ✅

• ✅ Basic VWAP calculation (testSinglePriceRecording, testMultiplePriceRecording)
• ✅ Volume recording from fees (testSinglePriceRecording - validates volume = fee * 100)
• ✅ Multi-trade accumulation (testConcreteMultipleRecordings - mathematical precision)
• ✅ 70% discount + capital inefficiency (testAdjustedVWAPCalculation)
• ✅ Zero volume edge cases (testZeroVolumeHandling, testInitialState)

Security & Edge Cases ✅

• ✅ Dormant whale protection (testDormantWhaleProtection - core security)
• ✅ Overflow handling (testOverflowHandling, testOverflowCompressionRatio)
• ✅ Compression preserves history (prevents whale manipulation)
• ✅ Extreme values (testLargeButSafeValues, testMinimalValues)
• ✅ Fuzz testing (testFuzzVWAPCalculation - random inputs)

Capital Inefficiency ✅

• ✅ Zero capital inefficiency (testAdjustedVWAPWithZeroCapitalInefficiency)
• ✅ Max capital inefficiency (testAdjustedVWAPWithMaxCapitalInefficiency)
• ✅ Variable impact testing (testAdjustedVWAPCalculation)

Result: VWAPTracker has comprehensive test coverage. No gaps remain.

---

LiquidityManager Integration Tests

Priority: HIGH

1. Anti-Arbitrage Strategy Validation ✅

Status: COMPLETED
Goal: Prove asymmetric slippage profile protects against trade-recenter-reverse attacks
Details: Verified ANCHOR (shallow) vs FLOOR/DISCOVERY (deep) liquidity creates expensive round-trip slippage Test Location: test/LiquidityManager.t.sol::testAntiArbitrageStrategyValidation() Results: 80% slippage loss, 17% anchor ratio, validates protection mechanism Priority Justification: Core protection mechanism against sophisticated arbitrage

2. Position Dependency Order Test

Status: MISSING
Goal: Verify _set() function order: ANCHOR → DISCOVERY → FLOOR with correct dependencies
Details: Test that discovery amount depends on anchor's pulledHarb, floor depends on final outstanding supply after all minting Test Location: Should be in test/LiquidityManager.t.sol Priority Justification: Validates economic logic behind position ordering

3. Floor Position VWAP Exclusivity Test

Status: MISSING
Goal: Prove only floor position uses VWAP, anchor/discovery use current tick
Details: Critical architectural verification - ensure VWAP only affects floor positioning for historical memory Test Location: Should be in test/LiquidityManager.t.sol Priority Justification: Validates separation of historical (floor) vs immediate (anchor/discovery) price responses

4. EthScarcity vs EthAbundance Scenarios

Status: MISSING
Goal: Test EthScarcity vs EthAbundance event emission and VWAP application logic
Details: Verify different VWAP usage when ETH reserves < vs > required buyback amount Test Location: Should be in test/LiquidityManager.t.sol

Priority: MEDIUM

5. Floor Position Discount Verification

Status: PARTIALLY COVERED
Goal: Verify floor position pricing uses adjusted VWAP (70% + capital inefficiency)
Details: Current testVWAPIntegrationValidation touches this but needs dedicated precision testing. Gap: Need exact discount formula verification in isolation.

Priority: LOW

6. Cross-Position Independence

Status: MISSING
Goal: Verify anchor/discovery positions unaffected by VWAP changes
Details: Ensure VWAP compression/changes don't affect non-floor positions. Note: Low priority as architecture makes this unlikely to break.

Completed ✅

✅ Anti-Arbitrage Strategy Validation

Status: Completed
Goal: Prove asymmetric slippage profile protects against trade-recenter-reverse attacks
File: test/LiquidityManager.t.sol::testAntiArbitrageStrategyValidation()
Results: 80% round-trip slippage loss, 17% anchor liquidity ratio, validates protection mechanism What it tests: Trade-recenter-reverse attack simulation, asymmetric liquidity profile validation, economic attack deterrent

✅ VWAP Integration Validation

Status: Completed
Goal: Validate VWAP system stability and cross-component behavior
File: test/LiquidityManager.t.sol::testVWAPIntegrationValidation()
What it tests: System stability, reasonable value ranges, floor positioning differences, cumulative data accumulation

---

Notes for Implementation

• Current test file: /home/ubuntu/dev/harb/onchain/test/LiquidityManager.t.sol
• Next recommended task: Position Dependency Order Test (highest remaining priority)
• Key insight discovered: Floor positioned at tick -176700 vs current -113852 shows 62k tick difference, confirming VWAP-based positioning
• Token ordering: HARB is token0 in test setup (DEFAULT_TOKEN0_IS_WETH = false)
• _set() Function Analysis: Position order ANCHOR → DISCOVERY → FLOOR reflects economic dependencies for anti-arbitrage protection

Test Architecture Pattern

Each test should:

1. Use _setupCustom() for custom scenarios
2. Include proper assertions (not just console.log)
3. Test specific functionality, not general integration
4. Consider token ordering implications (HARB/WETH vs WETH/HARB)
5. Verify economic logic makes sense