johba/harb
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions
harb/onchain/test
History
johba 5c4ceaf78d fix: No negative-mantissa guard in OptimizerV3Push3 (#650) (#966) 
Fixes #650

## Changes
Add require(inputs[k].mantissa >= 0, 'negative mantissa') for all 8 input slots inside the existing validation loop in OptimizerV3Push3.sol, matching the guard pattern in Optimizer.sol lines 372-374. Added 3 tests covering slots 0, 1, and 5 to confirm revert on negative mantissa.

Co-authored-by: openhands <openhands@all-hands.dev>
Reviewed-on: https://codeberg.org/johba/harb/pulls/966
Reviewed-by: Disinto_bot <disinto_bot@noreply.codeberg.org>
2026-03-19 11:30:18 +01:00
..
abstracts fix: address review findings for anchorWidth guard (#817) 2026-03-15 22:04:13 +00:00
helpers fix: address AI review findings for #706 recenterAccess removal 2026-03-14 09:15:48 +00:00
libraries Add Solidity linting with solhint, Foundry formatter, and pre-commit hooks (#51) 2025-10-04 15:17:09 +02:00
mocks fix: feat: Push3 input redesign — normalized indicators instead of raw protocol values (#635) (#649) 2026-03-13 07:53:46 +01:00
EthScarcityAbundance.t.sol fix: address AI review findings for #706 recenterAccess removal 2026-03-14 09:15:48 +00:00
FitnessEvaluator.t.sol fix: fix: FitnessEvaluator.t.sol broken on Base mainnet fork (#780) 2026-03-15 02:13:04 +00:00
FuzzingAnalyzerBugs.t.sol fix: address AI review findings for #706 recenterAccess removal 2026-03-14 09:15:48 +00:00
Kraiken.t.sol fix: add symmetric InvalidAddress guard to setLiquidityManager (#935) 2026-03-18 09:45:43 +00:00
LiquidityManager.t.sol fix: address review feedback for #958 2026-03-18 22:06:13 +00:00
Optimizer.t.sol fix: Optimizer.sol base class only guards slots 0 and 1 (#968) 2026-03-18 18:24:18 +00:00
OptimizerV3Push3.t.sol fix: No negative-mantissa guard in OptimizerV3Push3 (#650) (#966) 2026-03-19 11:30:18 +01:00
ReplayProfitableScenario.t.sol fix: address AI review findings for #706 recenterAccess removal 2026-03-14 09:15:48 +00:00
Stake.t.sol fix: Test coverage: Stake.sol to 100% (#284) 2026-02-26 03:59:20 +00:00
SupplyCorruption.t.sol fix: address AI review findings for #706 recenterAccess removal 2026-03-14 09:15:48 +00:00
VWAPFloorProtection.t.sol fix: address AI review findings for #706 recenterAccess removal 2026-03-14 09:15:48 +00:00
VWAPTracker.t.sol fix: Backtesting #5: Position tracking + P&L metrics (#319) 2026-02-27 11:23:18 +00:00