fix: match Position History background to Active Positions (#9) #10

Merged
dev-bot merged 1 commit from fix/issue-8 into master 2026-04-05 18:14:02 +00:00
Owner

Closes #9

Adds the same dark background (#07111B) to CollapseHistory that CollapseActive already has. One-line CSS fix.

Closes #9 Adds the same dark background (#07111B) to CollapseHistory that CollapseActive already has. One-line CSS fix.
johba added 1 commit 2026-04-05 18:11:20 +00:00
CollapseHistory was missing the dark background override that
CollapseActive has, causing white background on the dark theme.
Collaborator

AI Review

Summary\n\nAdds background-color: #07111B to .f-collapse-history in CollapseHistory.vue, bringing it in line with the identical rule already present in CollapseActive.vue:287.\n\n### Verification\n\n- Color value: #07111B matches exactly.\n- SASS selector depth: placed correctly inside &.f-collapse-history, consistent with how CollapseActive scopes its background.\n- No side effects: the added rule is the outermost style for the history variant and does not override any more-specific rules within the block.\n\nNo issues found.

Verdict

APPROVE — One-line CSS fix applies the correct background color to CollapseHistory, matching CollapseActive exactly.


Reviewed at c6e8f06 | AGENTS.md

## AI Review <!-- reviewed: c6e8f06a7fbe59276862fa8cc62dc1703050d70a --> ### Summary\n\nAdds `background-color: #07111B` to `.f-collapse-history` in `CollapseHistory.vue`, bringing it in line with the identical rule already present in `CollapseActive.vue:287`.\n\n### Verification\n\n- **Color value**: `#07111B` matches exactly.\n- **SASS selector depth**: placed correctly inside `&.f-collapse-history`, consistent with how `CollapseActive` scopes its background.\n- **No side effects**: the added rule is the outermost style for the history variant and does not override any more-specific rules within the block.\n\nNo issues found. ### Verdict **APPROVE** — One-line CSS fix applies the correct background color to CollapseHistory, matching CollapseActive exactly. --- *Reviewed at `c6e8f06` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-05 18:12:31 +00:00
Dismissed
review-bot left a comment
Collaborator

AI Review: APPROVE — One-line CSS fix applies the correct background color to CollapseHistory, matching CollapseActive exactly.

AI Review: **APPROVE** — One-line CSS fix applies the correct background color to CollapseHistory, matching CollapseActive exactly.
Collaborator

AI Review

Summary

This is a minimal CSS fix. The change adds background-color: #07111B to .f-collapse-history in CollapseHistory.vue, matching the identical declaration already present in CollapseActive.vue at line 287.

Verification

  • CollapseActive.vue:287 already has background-color: #07111B under the same SASS pattern.
  • The new line is placed correctly in the SASS hierarchy — directly under &.f-collapse-history, before the nested rules.
  • No logic, imports, security surface, or architecture concerns introduced.

Verdict

Change is correct and complete. No issues found.

Verdict

APPROVE — One-line CSS fix correctly aligns CollapseHistory background with CollapseActive; no logic, security, or correctness concerns.


Reviewed at c6e8f06 | AGENTS.md

## AI Review <!-- reviewed: c6e8f06a7fbe59276862fa8cc62dc1703050d70a --> ### Summary This is a minimal CSS fix. The change adds `background-color: #07111B` to `.f-collapse-history` in `CollapseHistory.vue`, matching the identical declaration already present in `CollapseActive.vue` at line 287. ### Verification - `CollapseActive.vue:287` already has `background-color: #07111B` under the same SASS pattern. - The new line is placed correctly in the SASS hierarchy — directly under `&.f-collapse-history`, before the nested rules. - No logic, imports, security surface, or architecture concerns introduced. ### Verdict Change is correct and complete. No issues found. ### Verdict **APPROVE** — One-line CSS fix correctly aligns CollapseHistory background with CollapseActive; no logic, security, or correctness concerns. --- *Reviewed at `c6e8f06` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-05 18:12:55 +00:00
review-bot left a comment
Collaborator

AI Review: APPROVE — One-line CSS fix correctly aligns CollapseHistory background with CollapseActive; no logic, security, or correctness concerns.

AI Review: **APPROVE** — One-line CSS fix correctly aligns CollapseHistory background with CollapseActive; no logic, security, or correctness concerns.
dev-bot merged commit baa501fa46 into master 2026-04-05 18:14:02 +00:00
dev-bot deleted branch fix/issue-8 2026-04-05 18:14:02 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: johba/harb#10
No description provided.