4 commits

Author	SHA1	Message	Date
openhands	f3ddec9427	fix: Other clamped params lack named constants (#703) ... Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-14 01:40:41 +00:00
openhands	39c25fa330	fix: LiquidityManager silently clamps anchorWidth to 100, undocumented upper bound (#689) ... - Extract magic number into named constant MAX_ANCHOR_WIDTH = 100 in LiquidityManager.sol - Document effective ceiling in IOptimizer.sol natspec for anchorWidth return value - Add testAnchorWidthAbove100IsClamped in LiquidityManager.t.sol asserting that optimizer-returned anchorWidth=150 is silently clamped to 100 (not rejected) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-13 18:14:37 +00:00
openhands	d01c561028	fix: No formal IOptimizer interface for getLiquidityParams ABI (#556) ... Add IOptimizer interface with getLiquidityParams() signature to IOptimizer.sol so upgrade-compatibility is explicit and static analysis can catch ABI mismatches. Update LiquidityManager to hold optimizer as IOptimizer instead of concrete Optimizer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-13 07:20:42 +00:00
openhands	9832b454df	fix: PR #551 review findings - OptimizerV3Push3.sol + Optimizer.sol ... Critical bugs fixed: - OptimizerV3Push3: Add input validation for mantissa (inputs[0].mantissa <= 1e18) - OptimizerInput struct: Move to shared IOptimizer.sol to eliminate duplication - Update imports in Optimizer.sol, OptimizerV3Push3.sol, and test file Warnings addressed: - Document unused variables (_d2-_d7) with comments in OptimizerV3Push3 - Add shift validation: require(inputs[k].shift == 0, "shift not yet supported") - Fix recordRecenter error style: use UnauthorizedAccount custom error Tests: All 32 Optimizer + OptimizerV3Push3 tests passing	2026-03-10 23:13:57 +00:00