Commit graph

16 commits

Author SHA1 Message Date
openhands
296c7a2dea fix: ARCHITECTURE.md staking pool bullet missing its own conditional guard (#892) 2026-03-17 10:49:05 +00:00
openhands
f491f30f90 fix: ARCHITECTURE.md staking pool bullet missing its own conditional guard (#892) 2026-03-17 10:26:47 +00:00
openhands
dc2de3d470 fix: ARCHITECTURE.md omits conditional guard on feeDestination exclusion (#663) 2026-03-16 18:06:57 +00:00
openhands
0d09f598d9 fix: Hardcoded TWAP/cooldown values not documented (#825)
Document MIN_RECENTER_INTERVAL (60 s, LiquidityManager.sol:61) and
PRICE_STABILITY_INTERVAL (300 s, PriceOracle.sol:14) in
docs/ARCHITECTURE.md and docs/PRODUCT-TRUTH.md so that agent-facing
and product-facing copy stays traceable to source constants.

Add an inline HTML comment in red-team-program.md next to the
hardcoded 60s/300s sentence pointing to the two source constants,
making drift detectable during code review.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-15 19:51:52 +00:00
openhands
d3917c551f fix: ThreePositionStrategy class comment still advertises 1-100% anchor width (#786)
- Fix class-level NatSpec: use accurate wording (width computed from
  anchorWidth param provided by Optimizer) instead of imprecise
  LiquidityManager attribution
- Fix inline comment in _setAnchorPosition (same stale 1-100% claim)
- Update PRODUCT-TRUTH.md and ARCHITECTURE.md which had the same
  incorrect 1-100% range claim

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-15 08:51:12 +00:00
openhands
0a59de9b12 fix: push3-evolution description missing crossover operator (#659) 2026-03-14 05:46:48 +00:00
openhands
b5cf1ea600 fix: ARCHITECTURE.md missing tools/ directory entry (#561) 2026-03-13 06:37:02 +00:00
openhands
b902b89e3b fix: address review findings — CREATE2 guard, transition test, docs
- LiquidityManager.setFeeDestination: add CREATE2 bypass guard — also
  blocks re-assignment when the current feeDestination has since acquired
  bytecode (was a plain address when set, contract deployed to it later)
- LiquidityManager.setFeeDestination: expand NatSpec to document the
  EOA-mutability trade-off and the CREATE2 guard explicitly
- Test: add testSetFeeDestinationEOAToContract_Locks covering the
  realistic EOA→contract transition (the primary lock-activation path)
- red-team.sh: add comment that DEPLOYER_PK is Anvil account-0 and must
  only be used against a local ephemeral Anvil instance
- ARCHITECTURE.md: document feeDestination conditional-lock semantics and
  contrast with Kraiken's strictly set-once liquidityManager/stakingPool

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-03-12 17:13:50 +00:00
openhands
e09a995733 fix: KRK fees to feeDestination undocumented (#458) 2026-03-06 00:32:18 +00:00
openhands
496a464baf fix: KRK fees to feeDestination undocumented (#458) 2026-03-06 00:01:28 +00:00
openhands
5c7b488753 docs: clarify fees go to protocol treasury, not holders
- Add Fee Destination section to PRODUCT-TRUTH.md
- Explicitly ban 'fees grow your KRK value' and 'auto-compounding' claims
- Clarify holder value comes from asymmetric slippage, not fee reinvestment
- Fix misleading 'floor always goes up if fee income exceeds sell pressure'
- Update ARCHITECTURE.md feeDestination annotation
2026-03-05 12:02:45 +01:00
openhands
6432c07b12 fix: correct txnBot description in ARCHITECTURE.md directory map 2026-03-03 04:56:40 +00:00
openhands
57b256b7e0 fix: services/txnBot missing from ARCHITECTURE.md directory map (#369) 2026-03-03 04:11:08 +00:00
openhands
e8c6070846 fix: kraiken-lib missing from ARCHITECTURE.md directory map (#342) 2026-02-28 11:20:50 +00:00
openhands
b66a8afcaa fix: \VueQueryPlugin\ possibly dead dependency (#195)
Clarify that @tanstack/vue-query is a required peer dependency of
@wagmi/vue, not a dead import. Add a comment in main.ts explaining the
rationale, and document the dependency in ARCHITECTURE.md and
landing/AGENTS.md.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-02-23 21:13:02 +00:00
openhands
0fb1ed4bf8 fix: address review — migration comment, link ring buffer constants (#170) 2026-02-22 18:56:36 +00:00