Merge pull request 'fix: Optimizer.sol also silently accepts negative mantissa inputs (#582)' (#621) from fix/issue-582 into master

onchain/src/Optimizer.sol

@@ -248,6 +248,9 @@ contract Optimizer is Initializable, UUPSUpgradeable {
         virtual
         returns (uint256 capitalInefficiency, uint256 anchorShare, uint24 anchorWidth, uint256 discoveryDepth)
     {
+        // Guard against negative mantissa — uint256() cast silently wraps negatives.
+        require(inputs[0].mantissa >= 0, "negative mantissa");
+        require(inputs[1].mantissa >= 0, "negative mantissa");
         // Extract slots 0 and 1 (shift=0 assumed — mantissa IS the value)
         uint256 percentageStaked = uint256(inputs[0].mantissa);
         uint256 averageTaxRate = uint256(inputs[1].mantissa);

onchain/test/Optimizer.t.sol

@@ -324,6 +324,26 @@ contract OptimizerTest is Test {
         assertEq(w, 10, "totalWidth < 10 should be clamped to minimum of 10");
     }
 
+    /**
+     * @notice calculateParams reverts when inputs[0].mantissa is negative
+     */
+    function testCalculateParamsRevertsOnNegativeMantissa0() public {
+        OptimizerInput[8] memory inputs;
+        inputs[0] = OptimizerInput({mantissa: -1, shift: 0});
+        vm.expectRevert("negative mantissa");
+        optimizer.calculateParams(inputs);
+    }
+
+    /**
+     * @notice calculateParams reverts when inputs[1].mantissa is negative
+     */
+    function testCalculateParamsRevertsOnNegativeMantissa1() public {
+        OptimizerInput[8] memory inputs;
+        inputs[1] = OptimizerInput({mantissa: -1, shift: 0});
+        vm.expectRevert("negative mantissa");
+        optimizer.calculateParams(inputs);
+    }
+
     /**
      * @notice Non-admin calling upgradeTo should revert with UnauthorizedAccount
      */