johba/harb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: CROSS_BROWSER_SPECS glob matches unintended conversion-funnel spec (#1154)

Browse source 
Change CROSS_BROWSER_SPECS from '07-*.spec.ts' to '07-landing-pages.spec.ts'
so the cross-browser/mobile matrix only runs the landing page spec, not the
wallet-context conversion funnel spec that was never designed for non-Chromium
browsers.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
johba 2026-03-25 08:29:10 +00:00
parent e16f342c81
commit fdcef58a9f
1 changed files with 20 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

40
playwright.config.ts
View file

@ -1,4 +1,4 @@
import { defineConfig, devices } from '@playwright/test';
import { defineConfig, devices } from "@playwright/test";
/**
* Cross-browser + mobile viewport matrix for E2E quality gate.
@ -10,16 +10,16 @@ import { defineConfig, devices } from '@playwright/test';
*/
// Lightweight spec for cross-browser/viewport validation.
// Only test 07 (landing pages) runs cross-browser — it uses the default { page }
// Only 07-landing-pages runs cross-browser — it uses the default { page }
// fixture and does not create wallet contexts, so it works cleanly in all browsers.
const CROSS_BROWSER_SPECS = '07-*.spec.ts';
const CROSS_BROWSER_SPECS = "07-landing-pages.spec.ts";
// Chromium-specific launch flags (not valid for Firefox/WebKit).
const CHROMIUM_ARGS = ['--disable-dev-shm-usage', '--no-sandbox'];
const CHROMIUM_ARGS = ["--disable-dev-shm-usage", "--no-sandbox"];
export default defineConfig({
testDir: './tests/e2e',
testMatch: process.env.CI ? '[0-9]*.spec.ts' : '**/*.spec.ts',
testDir: "./tests/e2e",
testMatch: process.env.CI ? "[0-9]*.spec.ts" : "**/*.spec.ts",
fullyParallel: false,
timeout: 10 * 60 * 1000,
expect: {
@ -34,51 +34,51 @@ export default defineConfig({
projects: [
/* ── Desktop browsers ─────────────────────────────────── */
{
name: 'chromium',
name: "chromium",
use: {
...devices['Desktop Chrome'],
...devices["Desktop Chrome"],
viewport: { width: 1280, height: 720 },
screen: { width: 1280, height: 720 },
launchOptions: { args: CHROMIUM_ARGS },
},
},
{
name: 'firefox',
name: "firefox",
use: {
...devices['Desktop Firefox'],
...devices["Desktop Firefox"],
viewport: { width: 1280, height: 720 },
screen: { width: 1280, height: 720 },
},
dependencies: ['chromium'],
dependencies: ["chromium"],
testMatch: CROSS_BROWSER_SPECS,
},
{
name: 'webkit',
name: "webkit",
use: {
...devices['Desktop Safari'],
...devices["Desktop Safari"],
viewport: { width: 1280, height: 720 },
screen: { width: 1280, height: 720 },
},
dependencies: ['chromium'],
dependencies: ["chromium"],
testMatch: CROSS_BROWSER_SPECS,
},
/* ── Mobile viewports ─────────────────────────────────── */
{
name: 'iphone',
name: "iphone",
use: {
...devices['iPhone 14'],
...devices["iPhone 14"],
},
dependencies: ['chromium'],
dependencies: ["chromium"],
testMatch: CROSS_BROWSER_SPECS,
},
{
name: 'android',
name: "android",
use: {
...devices['Pixel 7'],
...devices["Pixel 7"],
launchOptions: { args: CHROMIUM_ARGS },
},
dependencies: ['chromium'],
dependencies: ["chromium"],
testMatch: CROSS_BROWSER_SPECS,
},
],