reworked stack

tests/setup/stack.ts

@@ -1,118 +1,49 @@
-import { exec as execCallback } from 'node:child_process';
-import { readFile } from 'node:fs/promises';
-import { dirname, resolve } from 'node:path';
-import { fileURLToPath } from 'node:url';
-import { promisify } from 'node:util';
 import {
   runAllHealthChecks,
   formatHealthCheckError,
-  type HealthCheckResult,
 } from './health-checks.js';
 
-const exec = promisify(execCallback);
+const DEFAULT_RPC_URL = 'http://127.0.0.1:8545';
+const DEFAULT_WEBAPP_URL = 'http://localhost:8081';
+const DEFAULT_GRAPHQL_URL = 'http://localhost:8081/graphql';
 
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = dirname(__filename);
-const repoRoot = resolve(__dirname, '..', '..');
-
-const DEFAULT_RPC_URL = process.env.STACK_RPC_URL ?? 'http://127.0.0.1:8545';
-const DEFAULT_WEBAPP_URL = process.env.STACK_WEBAPP_URL ?? 'http://localhost:5173';
-const DEFAULT_GRAPHQL_URL = process.env.STACK_GRAPHQL_URL ?? 'http://localhost:42069/graphql';
-
-let stackStarted = false;
-
-async function cleanupContainers(): Promise<void> {
-  try {
-    await run("podman pod ps -q --filter name=harb | xargs -r podman pod rm -f || true");
-    await run("podman ps -aq --filter name=harb | xargs -r podman rm -f || true");
-  } catch (error) {
-    console.warn('[stack] Failed to cleanup containers', error);
-  }
-}
-
-function delay(ms: number): Promise<void> {
-  return new Promise(resolveDelay => setTimeout(resolveDelay, ms));
-}
-
-async function run(command: string): Promise<void> {
-  await exec(command, { cwd: repoRoot, shell: true });
+export interface StackConfig {
+  rpcUrl: string;
+  webAppUrl: string;
+  graphqlUrl: string;
 }
 
 /**
- * Run functional health checks that verify services are actually usable, not just running
+ * Get stack configuration from environment variables.
+ * Tests should NOT start their own stack - they require a pre-existing healthy stack.
  */
-async function checkStackFunctional(
-  rpcUrl: string,
-  webAppUrl: string,
-  graphqlUrl: string
-): Promise<void> {
-  const results = await runAllHealthChecks({ rpcUrl, webAppUrl, graphqlUrl });
+export function getStackConfig(): StackConfig {
+  return {
+    rpcUrl: process.env.STACK_RPC_URL ?? DEFAULT_RPC_URL,
+    webAppUrl: process.env.STACK_WEBAPP_URL ?? DEFAULT_WEBAPP_URL,
+    graphqlUrl: process.env.STACK_GRAPHQL_URL ?? DEFAULT_GRAPHQL_URL,
+  };
+}
+
+/**
+ * Validate that a healthy stack exists and is functional.
+ * If validation fails, the test run should exit immediately.
+ *
+ * Tests do NOT manage stack lifecycle - stack must be started externally via:
+ *   ./scripts/dev.sh start
+ */
+export async function validateStackHealthy(config: StackConfig): Promise<void> {
+  const results = await runAllHealthChecks(config);
 
   const failures = results.filter(r => !r.success);
   if (failures.length > 0) {
-    throw new Error(formatHealthCheckError(results));
-  }
-}
-
-export async function startStack(): Promise<void> {
-  if (stackStarted) {
-    return;
-  }
-
-  await cleanupContainers();
-
-  await run('nohup ./scripts/dev.sh start > ./tests/.stack.log 2>&1 &');
-  stackStarted = true;
-}
-
-export async function waitForStackReady(options: {
-  rpcUrl?: string;
-  webAppUrl?: string;
-  graphqlUrl?: string;
-  timeoutMs?: number;
-  pollIntervalMs?: number;
-} = {}): Promise<void> {
-  const rpcUrl = options.rpcUrl ?? DEFAULT_RPC_URL;
-  const webAppUrl = options.webAppUrl ?? DEFAULT_WEBAPP_URL;
-  const graphqlUrl = options.graphqlUrl ?? DEFAULT_GRAPHQL_URL;
-  const timeoutMs = options.timeoutMs ?? 180_000;
-  const pollIntervalMs = options.pollIntervalMs ?? 2_000;
-
-  const start = Date.now();
-  const errors = new Map<string, string>();
-
-  while (Date.now() - start < timeoutMs) {
-    try {
-      await checkStackFunctional(rpcUrl, webAppUrl, graphqlUrl);
-      console.log('✅ All stack health checks passed');
-      return;
-    } catch (error) {
-      const message = error instanceof Error ? error.message : String(error);
-      errors.set('lastError', message);
-      await delay(pollIntervalMs);
-    }
-  }
-
-  const logPath = resolve(repoRoot, 'tests', '.stack.log');
-  let logTail = '';
-  try {
-    const contents = await readFile(logPath, 'utf-8');
-    logTail = contents.split('\n').slice(-40).join('\n');
-  } catch (readError) {
-    logTail = `Unable to read stack log: ${readError}`;
-  }
-
-  throw new Error(`Stack failed to become ready within ${timeoutMs}ms\nLast error: ${errors.get('lastError')}\nLog tail:\n${logTail}`);
-}
-
-export async function stopStack(): Promise<void> {
-  if (!stackStarted) {
-    return;
-  }
-
-  try {
-    await run('./scripts/dev.sh stop');
-  } finally {
-    stackStarted = false;
+    const errorMessage = formatHealthCheckError(results);
+    console.error('\n❌ Stack health validation failed');
+    console.error('Tests require a pre-existing healthy stack.');
+    console.error('Start the stack with: ./scripts/dev.sh start\n');
+    console.error(errorMessage);
+    process.exit(1);
   }
+
+  console.log('✅ Stack health validation passed');
 }