johba/harb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: address review feedback for #958

Browse source 
- Document new LiquidityManager events in kraiken-lib/src/version.ts per
  AGENTS.md pre-PR checklist item 6 (Kraiken VERSION unchanged; no ponder
  subscriber impact)
- Add vm.expectEmit assertions to testSetFeeDestinationLocked_Reverts for
  the setup call that now emits FeeDestinationSet + FeeDestinationLocked

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
openhands 2026-03-18 22:06:13 +00:00
parent d08388240d
commit f33d5e932d
2 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
kraiken-lib/src/version.ts
View file

@ -25,6 +25,10 @@ export const STACK_META_ID = 'stack-meta';
* Version History: * Version History:
* - v1: Initial deployment (30-tier TAX_RATES, index-based staking) * - v1: Initial deployment (30-tier TAX_RATES, index-based staking)
* - v2: OptimizerV3, VWAP mirror floor, directional VWAP recording * - v2: OptimizerV3, VWAP mirror floor, directional VWAP recording
*
* LiquidityManager event additions (no Kraiken VERSION bump):
* - FeeDestinationSet(address indexed newDest) — emitted on every setFeeDestination() assignment
* - FeeDestinationLocked(address indexed dest) — emitted when the fee destination lock engages
*/ */
export const COMPATIBLE_CONTRACT_VERSIONS = [1, 2]; export const COMPATIBLE_CONTRACT_VERSIONS = [1, 2];

4
onchain/test/LiquidityManager.t.sol
View file

@ -1035,6 +1035,10 @@ contract LiquidityManagerTest is UniSwapHelper {
*/ */
function testSetFeeDestinationLocked_Reverts() public { function testSetFeeDestinationLocked_Reverts() public {
LiquidityManager freshLm = new LiquidityManager(address(factory), address(weth), address(harberg), address(optimizer)); LiquidityManager freshLm = new LiquidityManager(address(factory), address(weth), address(harberg), address(optimizer));
vm.expectEmit(true, false, false, false, address(freshLm));
emit LiquidityManager.FeeDestinationSet(address(harberg));
vm.expectEmit(true, false, false, false, address(freshLm));
emit LiquidityManager.FeeDestinationLocked(address(harberg));
freshLm.setFeeDestination(address(harberg)); freshLm.setFeeDestination(address(harberg));
vm.expectRevert("fee destination locked"); vm.expectRevert("fee destination locked");
freshLm.setFeeDestination(makeAddr("anyAddr")); freshLm.setFeeDestination(makeAddr("anyAddr"));