johba/harb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Kraiken.setStakingPool() allows stakingPool == liquidityManager with no guard (#935)

Browse source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
openhands 2026-03-18 08:09:43 +00:00
parent 256377ef1f
commit f3238a9685
2 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
onchain/src/Kraiken.sol
View file

@ -43,6 +43,7 @@ contract Kraiken is ERC20, ERC20Permit {
// Custom errors
error ZeroAddressInSetter();
error AddressAlreadySet();
error InvalidAddress();
// Modifier to restrict access to the liquidity manager
modifier onlyLiquidityManager() {
@ -81,6 +82,7 @@ contract Kraiken is ERC20, ERC20Permit {
function setStakingPool(address stakingPool_) external {
require(msg.sender == deployer, "only deployer");
if (address(0) == stakingPool_) revert ZeroAddressInSetter();
if (stakingPool_ == liquidityManager) revert InvalidAddress();
if (stakingPool != address(0)) revert AddressAlreadySet();
stakingPool = stakingPool_;
}

8
onchain/test/Kraiken.t.sol
View file

@ -207,6 +207,14 @@ contract KraikenTest is Test {
kraiken.setStakingPool(makeAddr("anotherStakingPool"));
}
function testSetStakingPoolRejectsLiquidityManager() public {
Kraiken freshKraiken = new Kraiken("KRAIKEN", "KRK");
address lm = makeAddr("liquidityManager");
freshKraiken.setLiquidityManager(lm);
vm.expectRevert(Kraiken.InvalidAddress.selector);
freshKraiken.setStakingPool(lm);
}
function testSetStakingPoolOnlyDeployer() public {
Kraiken freshKraiken = new Kraiken("KRAIKEN", "KRK");
address nonDeployer = makeAddr("nonDeployer");