johba/harb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: add symmetric InvalidAddress guard to setLiquidityManager (#935)

Browse source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
openhands 2026-03-18 09:45:43 +00:00
parent 4c1a3940ec
commit ee867b256e
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
onchain/src/Kraiken.sol
View file

@ -69,6 +69,7 @@ contract Kraiken is ERC20, ERC20Permit {
function setLiquidityManager(address liquidityManager_) external { function setLiquidityManager(address liquidityManager_) external {
require(msg.sender == deployer, "only deployer"); require(msg.sender == deployer, "only deployer");
if (address(0) == liquidityManager_) revert ZeroAddressInSetter(); if (address(0) == liquidityManager_) revert ZeroAddressInSetter();
if (liquidityManager_ == stakingPool) revert InvalidAddress();
if (liquidityManager != address(0)) revert AddressAlreadySet(); if (liquidityManager != address(0)) revert AddressAlreadySet();
liquidityManager = liquidityManager_; liquidityManager = liquidityManager_;
} }

8
onchain/test/Kraiken.t.sol
View file

@ -187,6 +187,14 @@ contract KraikenTest is Test {
kraiken.setLiquidityManager(makeAddr("anotherLiquidityManager")); kraiken.setLiquidityManager(makeAddr("anotherLiquidityManager"));
} }
function testSetLiquidityManagerRejectsStakingPool() public {
Kraiken freshKraiken = new Kraiken("KRAIKEN", "KRK");
address sp = makeAddr("stakingPool");
freshKraiken.setStakingPool(sp);
vm.expectRevert(Kraiken.InvalidAddress.selector);
freshKraiken.setLiquidityManager(sp);
}
function testSetLiquidityManagerOnlyDeployer() public { function testSetLiquidityManagerOnlyDeployer() public {
Kraiken freshKraiken = new Kraiken("KRAIKEN", "KRK"); Kraiken freshKraiken = new Kraiken("KRAIKEN", "KRK");
address nonDeployer = makeAddr("nonDeployer"); address nonDeployer = makeAddr("nonDeployer");