johba/harb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: use toHaveText to correctly await swap completion after testId migration

Browse source 
getByTestId('swap-buy-button').waitFor({ state: 'visible' }) resolved
immediately because the button is always rendered; only its text changes.
Replace with expect(...).toHaveText('Buy KRK', { timeout: 60_000 }) to
correctly gate on the button returning to its idle state.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
openhands 2026-03-02 23:47:53 +00:00
parent 68601c255a
commit ed5db3b000
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
scripts/harb-evaluator/helpers/swap.ts
View file

@ -97,7 +97,7 @@ export async function buyKrk(page: Page, ethAmount: string): Promise<void> {
try { try {
await page.getByRole('button', { name: /Submitting/i }).waitFor({ state: 'visible', timeout: 5_000 }); await page.getByRole('button', { name: /Submitting/i }).waitFor({ state: 'visible', timeout: 5_000 });
console.log('[swap] Swap in progress...'); console.log('[swap] Swap in progress...');
await page.getByTestId('swap-buy-button').waitFor({ state: 'visible', timeout: 60_000 }); await expect(page.getByTestId('swap-buy-button')).toHaveText('Buy KRK', { timeout: 60_000 });
console.log('[swap] Swap completed'); console.log('[swap] Swap completed');
} catch { } catch {
// Swap completed before the Submitting state could be observed // Swap completed before the Submitting state could be observed

2
tests/e2e/01-acquire-and-stake.spec.ts
View file

@ -184,7 +184,7 @@ test.describe('Acquire & Stake', () => {
try { try {
await page.getByRole('button', { name: /Submitting/i }).waitFor({ state: 'visible', timeout: 5_000 }); await page.getByRole('button', { name: /Submitting/i }).waitFor({ state: 'visible', timeout: 5_000 });
console.log('[TEST] Swap initiated, waiting for completion...'); console.log('[TEST] Swap initiated, waiting for completion...');
await page.getByTestId('swap-buy-button').waitFor({ state: 'visible', timeout: 60_000 }); await expect(page.getByTestId('swap-buy-button')).toHaveText('Buy KRK', { timeout: 60_000 });
console.log('[TEST] Swap completed!'); console.log('[TEST] Swap completed!');
} catch (e) { } catch (e) {
console.log('[TEST] No "Submitting" state detected, swap may have completed instantly'); console.log('[TEST] No "Submitting" state detected, swap may have completed instantly');

2
tests/e2e/02-max-stake-all-tax-rates.spec.ts
View file

@ -193,7 +193,7 @@ test.describe('Max Stake All Tax Rates', () => {
console.log('[TEST] Waiting for swap to process...'); console.log('[TEST] Waiting for swap to process...');
try { try {
await page.getByRole('button', { name: /Submitting/i }).waitFor({ state: 'visible', timeout: 5_000 }); await page.getByRole('button', { name: /Submitting/i }).waitFor({ state: 'visible', timeout: 5_000 });
await page.getByTestId('swap-buy-button').waitFor({ state: 'visible', timeout: 60_000 }); await expect(page.getByTestId('swap-buy-button')).toHaveText('Buy KRK', { timeout: 60_000 });
console.log('[TEST] Swap completed!'); console.log('[TEST] Swap completed!');
} catch (e) { } catch (e) {
console.log('[TEST] Swap may have completed instantly'); console.log('[TEST] Swap may have completed instantly');