fix: fix: wallet connector panel not rendering at standard viewports — blocks all user funnels (#1156)

Root cause: the test wallet provider's eth_accounts and getProviderState
always returned the account address regardless of connection state. This
caused wagmi to auto-connect via EIP-6963 provider discovery, skipping
the 'disconnected' status entirely. As a result, .connect-button--disconnected
never rendered and .connectors-element was never shown.

Changes:
- wallet-provider: eth_accounts returns [] when not connected (EIP-1193 compliant)
- wallet-provider: getProviderState returns empty accounts when not connected
- All wallet connection helpers: handle auto-reconnect case, increase timeout
  for wagmi to settle into disconnected state (5s → 10s)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

scripts/harb-evaluator/helpers/wallet.ts

@@ -43,10 +43,17 @@ export async function connectWallet(page: Page): Promise<void> {
   const screenWidth = await page.evaluate(() => window.screen.width);
   console.log(`[wallet] screen.width = ${screenWidth}`);
 
+  // Check if wallet is already connected (e.g. wagmi auto-reconnected from storage)
+  const connectedButton = page.locator('.connect-button--connected').first();
+  if (await connectedButton.isVisible({ timeout: 1_000 }).catch(() => false)) {
+    console.log('[wallet] Wallet already connected (auto-reconnect)');
+    return;
+  }
+
   let panelOpened = false;
 
   const connectButton = page.locator('.connect-button--disconnected').first();
-  if (await connectButton.isVisible({ timeout: 5_000 })) {
+  if (await connectButton.isVisible({ timeout: 10_000 })) {
     console.log('[wallet] Found desktop Connect button, clicking...');
     await connectButton.click();
     panelOpened = true;

tests/e2e/01-acquire-and-stake.spec.ts

@@ -93,13 +93,17 @@ test.describe('Acquire & Stake', () => {
       // We expect the desktop Connect button to be visible.
       console.log('[TEST] Looking for Connect button...');
 
-      // Desktop Connect button
+      // Check if wallet already connected (wagmi may auto-reconnect from storage)
+      const alreadyConnected = page.locator('.connect-button--connected').first();
+      if (await alreadyConnected.isVisible({ timeout: 1_000 }).catch(() => false)) {
+        console.log('[TEST] Wallet already connected (auto-reconnect), skipping connect flow');
+      } else {
+        // Desktop Connect button — wait up to 10s for wagmi to settle into disconnected state
         const connectButton = page.locator('.connect-button--disconnected').first();
 
         let panelOpened = false;
 
-      // Wait for the Connect button with a reasonable timeout
+        if (await connectButton.isVisible({ timeout: 10_000 })) {
-      if (await connectButton.isVisible({ timeout: 5_000 })) {
           console.log('[TEST] Found desktop Connect button, clicking...');
           await connectButton.click();
           panelOpened = true;
@@ -138,6 +142,7 @@ test.describe('Acquire & Stake', () => {
             console.log('[TEST] WARNING: No wallet connector found in panel');
           }
         }
+      }
 
       // Check if wallet shows as connected in UI
       console.log('[TEST] Checking for wallet display...');

tests/e2e/02-max-stake-all-tax-rates.spec.ts

@@ -114,13 +114,17 @@ test.describe('Max Stake All Tax Rates', () => {
       // We expect the desktop Connect button to be visible.
       console.log('[TEST] Looking for Connect button...');
 
-      // Desktop Connect button
+      // Check if wallet already connected (wagmi may auto-reconnect from storage)
+      const alreadyConnected = page.locator('.connect-button--connected').first();
+      if (await alreadyConnected.isVisible({ timeout: 1_000 }).catch(() => false)) {
+        console.log('[TEST] Wallet already connected (auto-reconnect), skipping connect flow');
+      } else {
+        // Desktop Connect button — wait up to 10s for wagmi to settle into disconnected state
         const connectButton = page.locator('.connect-button--disconnected').first();
 
         let panelOpened = false;
 
-      // Wait for the Connect button with a reasonable timeout
+        if (await connectButton.isVisible({ timeout: 10_000 })) {
-      if (await connectButton.isVisible({ timeout: 5_000 })) {
           console.log('[TEST] Found desktop Connect button, clicking...');
           await connectButton.click();
           panelOpened = true;
@@ -159,6 +163,7 @@ test.describe('Max Stake All Tax Rates', () => {
             console.log('[TEST] WARNING: No wallet connector found in panel');
           }
         }
+      }
 
       // Verify wallet connection
       console.log('[TEST] Checking for wallet display...');

tests/e2e/usertest/helpers.ts

@@ -148,10 +148,21 @@ export async function connectWallet(page: Page): Promise<void> {
     window.dispatchEvent(new Event('resize'));
   });
 
-  // Try desktop Connect button first
+  // Wait for wagmi to settle — the connect button or connected display must appear.
+  // After the wallet-provider fix, eth_accounts returns [] when not connected,
+  // so wagmi should land on 'disconnected' status and render the connect button.
   const connectButton = page.locator('.connect-button--disconnected').first();
+  const connectedButton = page.locator('.connect-button--connected').first();
 
-  if (await connectButton.isVisible({ timeout: 5_000 })) {
+  // Wait for either the disconnect button (normal case) or connected button (auto-reconnect)
+  const desktopButton = page.locator('.connect-button--disconnected, .connect-button--connected').first();
+
+  if (await desktopButton.isVisible({ timeout: 10_000 })) {
+    if (await connectedButton.isVisible({ timeout: 500 }).catch(() => false)) {
+      // Wallet already connected (e.g. wagmi reconnected from storage) — skip connect flow
+      console.log('[HELPER] Wallet already connected (auto-reconnect)');
+    } else {
+      // Desktop connect button found — click to open connector panel
       console.log('[HELPER] Found desktop Connect button');
       await connectButton.click();
       // Wait for the connector panel to open — .connectors-element appearing is the observable event
@@ -159,6 +170,7 @@ export async function connectWallet(page: Page): Promise<void> {
       await injectedConnector.waitFor({ state: 'visible', timeout: 10_000 });
       console.log('[HELPER] Clicking wallet connector...');
       await injectedConnector.click();
+    }
   } else {
     // Try mobile fallback
     const mobileLoginIcon = page.locator('.navbar-end svg').first();

tests/setup/wallet-provider.ts

@@ -107,7 +107,7 @@ export async function createWalletContext(
               emit('accountsChanged', [account]);
               return [account];
             case 'eth_accounts':
-              return [account];
+              return connected ? [account] : [];
             case 'eth_chainId':
               return cidHex;
             case 'net_version':
@@ -160,7 +160,7 @@ export async function createWalletContext(
         requestPermissions: () =>
           Promise.resolve([{ parentCapability: 'eth_accounts' }]),
         getProviderState: async () => ({
-          accounts: [account],
+          accounts: connected ? [account] : [],
           chainId: cidHex,
           isConnected: connected,
         }),