johba/harb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request 'fix: Optimizer.sol base class only guards slots 0 and 1 (#968)' (#969) from fix/issue-968 into master

Browse source
This commit is contained in:
johba 2026-03-18 19:44:55 +01:00
commit da672070a6
2 changed files with 15 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
onchain/src/Optimizer.sol
View file

@ -370,8 +370,9 @@ contract Optimizer is Initializable, UUPSUpgradeable, IOptimizer {
returns (uint256 capitalInefficiency, uint256 anchorShare, uint24 anchorWidth, uint256 discoveryDepth)
{
// Guard against negative mantissa — uint256() cast silently wraps negatives.
require(inputs[0].mantissa >= 0, "negative mantissa");
require(inputs[1].mantissa >= 0, "negative mantissa");
for (uint256 k; k < 8; k++) {
require(inputs[k].mantissa >= 0, "negative mantissa");
}
// Extract slots 0 and 1 (shift=0 assumed — mantissa IS the value)
uint256 percentageStaked = uint256(inputs[0].mantissa);
uint256 averageTaxRate = uint256(inputs[1].mantissa);

12
onchain/test/Optimizer.t.sol
View file

@ -347,6 +347,18 @@ contract OptimizerTest is Test {
optimizer.calculateParams(inputs);
}
/**
* @notice calculateParams reverts when any of inputs[2..7].mantissa is negative
*/
function testCalculateParamsRevertsOnNegativeMantissaSlots2to7() public {
for (uint256 k = 2; k < 8; k++) {
OptimizerInput[8] memory inputs;
inputs[k] = OptimizerInput({mantissa: -1, shift: 0});
vm.expectRevert("negative mantissa");
optimizer.calculateParams(inputs);
}
}
/**
* @notice Non-admin calling upgradeTo should revert with UnauthorizedAccount
*/