From cd459bb9b0a9e201cafb1a3d6a1d6e9d43b7e618 Mon Sep 17 00:00:00 2001 From: openhands Date: Thu, 5 Mar 2026 05:53:19 +0000 Subject: [PATCH] fix: correct buyKrk call sites for new opts param, add eslint-disable for polling loop - no-dilution.spec.ts: pass undefined for opts, screenshotPrefix as 4th arg - swap.ts: add eslint-disable-next-line for eth_getFilterLogs polling delay --- scripts/harb-evaluator/helpers/swap.ts | 1 + .../scenarios/passive-confidence/no-dilution.spec.ts | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/harb-evaluator/helpers/swap.ts b/scripts/harb-evaluator/helpers/swap.ts index 9c991df..93793fe 100644 --- a/scripts/harb-evaluator/helpers/swap.ts +++ b/scripts/harb-evaluator/helpers/swap.ts @@ -154,6 +154,7 @@ export async function buyKrk(page: Page, ethAmount: string, opts?: BuyKrkOptions console.log(`[swap] Transfer event received (${logs.length} log(s))`); break; } + // eslint-disable-next-line no-restricted-syntax -- Polling with timeout: eth_getFilterLogs is HTTP-only polling (not push). See AGENTS.md #Engineering Principles. await new Promise(r => setTimeout(r, 200)); } // Clean up filter diff --git a/scripts/harb-evaluator/scenarios/passive-confidence/no-dilution.spec.ts b/scripts/harb-evaluator/scenarios/passive-confidence/no-dilution.spec.ts index 6178310..8e18b63 100644 --- a/scripts/harb-evaluator/scenarios/passive-confidence/no-dilution.spec.ts +++ b/scripts/harb-evaluator/scenarios/passive-confidence/no-dilution.spec.ts @@ -57,7 +57,7 @@ test('passive holders are not diluted', async ({ browser }) => { await connectWallet(pageA); console.log('[TEST] Wallet A buying 1 ETH of KRK...'); - await buyKrk(pageA, '1', 'walletA'); + await buyKrk(pageA, '1', undefined, 'walletA'); const krkBalanceA = await getKrkBalance(config.rpcUrl, config.contracts.Kraiken, ADDRESS_A); console.log(`[TEST] Wallet A KRK balance after buy: ${krkBalanceA}`); @@ -96,7 +96,7 @@ test('passive holders are not diluted', async ({ browser }) => { await connectWallet(pageB); console.log('[TEST] Wallet B buying 5 ETH of KRK...'); - await buyKrk(pageB, '5', 'walletB'); + await buyKrk(pageB, '5', undefined, 'walletB'); const krkBalanceB = await getKrkBalance(config.rpcUrl, config.contracts.Kraiken, ADDRESS_B); console.log(`[TEST] Wallet B KRK balance after buy: ${krkBalanceB}`);