From a8defd10b45e869d1c618422679f88d06943948c Mon Sep 17 00:00:00 2001 From: openhands Date: Fri, 6 Mar 2026 17:32:02 +0000 Subject: [PATCH] fix: unstakePosition() has no error handling at all (#482) Wrap the entire unstakePosition() body in try/catch/finally so that errors from exitPosition(), loadActivePositions(), and loadPositions() are caught, displayed to the user via the existing error ref, and loading state is always reset correctly. Co-Authored-By: Claude Sonnet 4.6 --- .../src/components/collapse/CollapseActive.vue | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/web-app/src/components/collapse/CollapseActive.vue b/web-app/src/components/collapse/CollapseActive.vue index c46f335..688bd23 100644 --- a/web-app/src/components/collapse/CollapseActive.vue +++ b/web-app/src/components/collapse/CollapseActive.vue @@ -214,12 +214,13 @@ async function changeTax(id: bigint, nextTaxRateIndex: number | null) { } async function unstakePosition() { - await unstake.exitPosition(props.id); - loading.value = true; - const POLL_INTERVAL_MS = 1000; - const TIMEOUT_MS = 30_000; - const deadline = Date.now() + TIMEOUT_MS; + error.value = null; try { + await unstake.exitPosition(props.id); + loading.value = true; + const POLL_INTERVAL_MS = 1000; + const TIMEOUT_MS = 30_000; + const deadline = Date.now() + TIMEOUT_MS; while (Date.now() < deadline) { const { positions } = await loadActivePositions(currentChainId.value); if (!positions.some(p => BigInt(p.id) === props.id)) break; @@ -227,6 +228,10 @@ async function unstakePosition() { await new Promise(resolve => setTimeout(resolve, POLL_INTERVAL_MS)); } await loadPositions(currentChainId.value); + } catch (err) { + // eslint-disable-next-line no-console + console.error('Failed to unstake position:', err); + error.value = 'Failed to unstake position.'; } finally { loading.value = false; }