From a8a5d1ab934a17625e2be0547b391c399075a844 Mon Sep 17 00:00:00 2001
From: openhands <openhands@all-hands.dev>
Date: Fri, 6 Mar 2026 05:02:10 +0000
Subject: [PATCH] fix: getErrorMessage silently ignores viem's shortMessage
 (#430)

viem's BaseError extends Error, so the instanceof Error branch was
firing and returning error.message before the isRecord branch could
check shortMessage. Check shortMessage first inside instanceof Error
so terse viem messages are shown to users instead of verbose full ones.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 packages/utils/src/index.ts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/packages/utils/src/index.ts b/packages/utils/src/index.ts
index aebb78d..fe49542 100644
--- a/packages/utils/src/index.ts
+++ b/packages/utils/src/index.ts
@@ -14,6 +14,9 @@ export function coerceString(value: unknown): string | null {
 
 export function getErrorMessage(error: unknown, fallback: string): string {
   if (error instanceof Error) {
+    // viem's BaseError extends Error and exposes a terse shortMessage; prefer it.
+    const short = coerceString((error as Record<string, unknown>).shortMessage);
+    if (short) return short;
     const msg = coerceString(error.message);
     if (msg) return msg;
   }