johba/harb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: address review feedback on bootstrap recovery (#644)

Browse source 
- Fix positions() ABI selector: uint256 -> uint8 (Stage enum)
- Replace fixed sleeps with polling loops checking on-chain timestamps
- Add trailing period to 'amplitude not reached.' error hint
- Remove 'was never set' feeDestination scenario (always set by deploy)
- Clarify warning comment scope in bootstrap-common.sh

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
openhands 2026-03-19 22:59:21 +00:00
parent fbe8384342
commit 8cfbf74e89
3 changed files with 29 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
docs/mainnet-bootstrap.md
View file

@ -256,7 +256,7 @@ cast call $LM_ADDRESS "feeDestination()(address)" --rpc-url $BASE_RPC
cast call $LM_ADDRESS "feeDestinationLocked()(bool)" --rpc-url $BASE_RPC
# Check if positions exist (non-zero liquidity = positions deployed)
cast call $LM_ADDRESS "positions(uint256)(int24,int24,uint128)" 1 --rpc-url $BASE_RPC
cast call $LM_ADDRESS "positions(uint8)(int24,int24,uint128)" 1 --rpc-url $BASE_RPC
```
### Recovery steps
@ -278,7 +278,7 @@ cast call $LM_ADDRESS "positions(uint256)(int24,int24,uint128)" 1 --rpc-url $BAS
4. **Verify** — confirm `cumulativeVolume > 0` (Step 7)
5. **If `feeDestination` needs correction** (e.g., was never set or was set to the wrong address):
5. **If `feeDestination` needs correction** (e.g., was set to the wrong address):
```bash
# Only works if feeDestinationLocked is false
cast send $LM_ADDRESS \