johba/harb
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: getByRole('button', { name: 'Buy' }).last() fragility is duplicated across e2e/01 and this scenario (#398)

Browse source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
openhands 2026-03-02 23:13:05 +00:00
parent 10643618f7
commit 68601c255a
4 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

6
scripts/harb-evaluator/helpers/swap.ts
View file

@ -80,13 +80,13 @@ export async function buyKrk(page: Page, ethAmount: string): Promise<void> {
await navigateSPA(page, '/app/get-krk');
await expect(page.getByRole('heading', { name: 'Get $KRK Tokens' })).toBeVisible({ timeout: 10_000 });
const swapInput = page.getByLabel('ETH to spend');
const swapInput = page.getByTestId('swap-amount-input');
await expect(swapInput).toBeVisible({ timeout: 15_000 });
await swapInput.fill(ethAmount);
await page.waitForTimeout(500);
const buyButton = page.getByRole('button', { name: 'Buy KRK' });
const buyButton = page.getByTestId('swap-buy-button');
await expect(buyButton).toBeVisible({ timeout: 5_000 });
await page.screenshot({ path: 'test-results/holdout-before-buy.png' });
@ -97,7 +97,7 @@ export async function buyKrk(page: Page, ethAmount: string): Promise<void> {
try {
await page.getByRole('button', { name: /Submitting/i }).waitFor({ state: 'visible', timeout: 5_000 });
console.log('[swap] Swap in progress...');
await page.getByRole('button', { name: 'Buy KRK' }).waitFor({ state: 'visible', timeout: 60_000 });
await page.getByTestId('swap-buy-button').waitFor({ state: 'visible', timeout: 60_000 });
console.log('[swap] Swap completed');
} catch {
// Swap completed before the Submitting state could be observed

6
tests/e2e/01-acquire-and-stake.spec.ts
View file

@ -170,11 +170,11 @@ test.describe('Acquire & Stake', () => {
await page.screenshot({ path: 'test-results/before-swap.png' });
const ethToSpendInput = page.getByLabel('ETH to spend');
const ethToSpendInput = page.getByTestId('swap-amount-input');
await expect(ethToSpendInput).toBeVisible({ timeout: 15_000 });
await ethToSpendInput.fill('0.05');
const buyButton = page.getByRole('button', { name: 'Buy KRK' });
const buyButton = page.getByTestId('swap-buy-button');
await expect(buyButton).toBeVisible();
console.log('[TEST] Clicking Buy KRK button...');
await buyButton.click();
@ -184,7 +184,7 @@ test.describe('Acquire & Stake', () => {
try {
await page.getByRole('button', { name: /Submitting/i }).waitFor({ state: 'visible', timeout: 5_000 });
console.log('[TEST] Swap initiated, waiting for completion...');
await page.getByRole('button', { name: 'Buy KRK' }).waitFor({ state: 'visible', timeout: 60_000 });
await page.getByTestId('swap-buy-button').waitFor({ state: 'visible', timeout: 60_000 });
console.log('[TEST] Swap completed!');
} catch (e) {
console.log('[TEST] No "Submitting" state detected, swap may have completed instantly');

6
tests/e2e/02-max-stake-all-tax-rates.spec.ts
View file

@ -181,11 +181,11 @@ test.describe('Max Stake All Tax Rates', () => {
await expect(page.getByRole('heading', { name: 'Get $KRK Tokens' })).toBeVisible({ timeout: 10_000 });
console.log('[TEST] Buying KRK tokens (swapping 5 ETH)...');
const ethToSpendInput = page.getByLabel('ETH to spend');
const ethToSpendInput = page.getByTestId('swap-amount-input');
await expect(ethToSpendInput).toBeVisible({ timeout: 15_000 });
await ethToSpendInput.fill('5');
const buyButton = page.getByRole('button', { name: 'Buy KRK' });
const buyButton = page.getByTestId('swap-buy-button');
await expect(buyButton).toBeVisible();
await buyButton.click();
@ -193,7 +193,7 @@ test.describe('Max Stake All Tax Rates', () => {
console.log('[TEST] Waiting for swap to process...');
try {
await page.getByRole('button', { name: /Submitting/i }).waitFor({ state: 'visible', timeout: 5_000 });
await page.getByRole('button', { name: 'Buy KRK' }).waitFor({ state: 'visible', timeout: 60_000 });
await page.getByTestId('swap-buy-button').waitFor({ state: 'visible', timeout: 60_000 });
console.log('[TEST] Swap completed!');
} catch (e) {
console.log('[TEST] Swap may have completed instantly');

4
web-app/src/components/LocalSwapWidget.vue
View file

@ -6,9 +6,9 @@
<template v-else>
<div class="swap-field">
<label for="local-swap-amount" class="swap-label">ETH to spend</label>
<input id="local-swap-amount" :value="swapAmount" @input="swapAmount = ($event.target as HTMLInputElement).value" type="number" min="0" step="0.01" class="swap-input" :disabled="swapping" />
<input id="local-swap-amount" data-testid="swap-amount-input" :value="swapAmount" @input="swapAmount = ($event.target as HTMLInputElement).value" type="number" min="0" step="0.01" class="swap-input" :disabled="swapping" />
</div>
<button class="swap-button" :disabled="swapping" @click="buyKrk">
<button class="swap-button" data-testid="swap-buy-button" :disabled="swapping" @click="buyKrk">
{{ swapping ? 'Submitting…' : 'Buy KRK' }}
</button>
<p class="swap-hint">Wraps ETH → WETH, approves the swap router, then trades into $KRK.</p>