fix: Optimizer and OptimizerV3 lack _disableInitializers() in constructor (#1055) (#1080)

Fixes #1055

## Changes
That notification is for the earlier background task which already completed — I retrieved its output and used it to diagnose and fix the failing test. The work is done.

Reviewed-on: https://codeberg.org/johba/harb/pulls/1080
Reviewed-by: Disinto_bot <disinto_bot@noreply.codeberg.org>

onchain/src/Optimizer.sol

@@ -86,6 +86,11 @@ interface ILiquidityManagerPositions {
  *   discoveryDepth       discovery liquidity density
  */
 contract Optimizer is Initializable, UUPSUpgradeable, IOptimizer {
+    /// @custom:oz-upgrades-unsafe-allow constructor
+    constructor() {
+        _disableInitializers();
+    }
+
     Kraiken private kraiken;
     Stake private stake;
 

onchain/src/OptimizerV3.sol

@@ -17,6 +17,11 @@ import { OptimizerV3Push3Lib } from "./OptimizerV3Push3Lib.sol";
  *        r40 -> ci, r39 -> anchorShare, r38 -> anchorWidth, r37 -> discoveryDepth
  */
 contract OptimizerV3 is Optimizer {
+    /// @custom:oz-upgrades-unsafe-allow constructor
+    constructor() {
+        _disableInitializers();
+    }
+
     function calculateParams(OptimizerInput[8] memory inputs)
         public
         pure

onchain/test/Optimizer.t.sol

@@ -30,16 +30,11 @@ contract OptimizerTest is Test {
         mockKraiken = new MockKraiken();
         mockStake = new MockStake();
 
-        // Deploy Optimizer implementation
+        // Deploy implementation and proxy
         Optimizer implementation = new Optimizer();
-
-        // Deploy proxy and initialize
         bytes memory initData = abi.encodeWithSelector(Optimizer.initialize.selector, address(mockKraiken), address(mockStake));
-
-        // For simplicity, we'll test the implementation directly
-        // In production, you'd use a proper proxy setup
-        optimizer = implementation;
-        optimizer.initialize(address(mockKraiken), address(mockStake));
+        ERC1967Proxy proxy = new ERC1967Proxy(address(implementation), initData);
+        optimizer = Optimizer(address(proxy));
     }
 
     /**