johba/harb
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

fix: OptimizerV3Push3 as IOptimizer always returns bear defaults — integration risk (#1063)

Browse source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
johba 2026-03-20 20:52:29 +00:00
parent 45142e762a
commit 62fc7957b0
4 changed files with 13 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
onchain/script/backtesting/BacktestRunner.s.sol
View file

@ -134,8 +134,8 @@ contract BacktestRunner is Script {
// ------------------------------------------------------------------
// KrAIken system deployment (follows DeployLocal.sol pattern)
//
// 1. Deploy OptimizerV3Push3 (no proxy — getLiquidityParams() uses zeroed
// inputs, returning bear-mode defaults on every recenter).
// 1. Deploy OptimizerV3Push3 (no proxy — getLiquidityParams() always reverts;
// LM's try/catch falls back to bear-mode defaults on every recenter).
// 2. Deploy LiquidityManager pointing at the shadow pool.
// 3. Wire BacktestKraiken.setLiquidityManager(lm).
// 4. Set feeDestination = sender.

8
onchain/script/backtesting/KrAIkenDeployer.sol
View file

@ -12,8 +12,8 @@ import { MockToken } from "./MockToken.sol";
struct KrAIkenSystem {
BacktestKraiken kraiken;
/// @dev OptimizerV3Push3 is used as the optimizer address. Its getLiquidityParams()
/// uses zeroed inputs (no on-chain stake data) and returns bear-mode defaults on
/// every recenter. This is intentional for backtesting.
/// always reverts; LM's try/catch then falls back to bear-mode defaults on every
/// recenter. This is intentional for backtesting.
OptimizerV3Push3 optimizer;
LiquidityManager lm;
}
@ -65,8 +65,8 @@ library KrAIkenDeployer {
returns (KrAIkenSystem memory sys)
{
// 1. Deploy OptimizerV3Push3.
// OptimizerV3Push3.getLiquidityParams() uses zeroed inputs (no stake data),
// so every recenter uses bear defaults — conservative and correct for a
// OptimizerV3Push3.getLiquidityParams() always reverts; LM's try/catch falls
// back to bear defaults on every recenter — conservative and correct for a
// baseline backtest.
OptimizerV3Push3 optimizer = new OptimizerV3Push3();