From 61ea25517cf534ce0e29494092044229e5e35acb Mon Sep 17 00:00:00 2001 From: johba Date: Mon, 18 Aug 2025 17:05:32 +0200 Subject: [PATCH] fix: Fix discovery position KRAIKEN amount calculation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The discovery position was incorrectly calculating ETH amount instead of KRAIKEN amount when determining how much to subtract from outstanding supply. This caused the floor position to be placed at extreme ticks (141k+) instead of bordering the anchor position. When token0isWeth=true: - Before: discoveryAmount = getAmount0 (ETH amount) - After: discoveryAmount = getAmount1 (KRAIKEN amount) This ensures the outstanding supply calculation properly excludes all KRAIKEN tokens locked in liquidity positions. šŸ¤– Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- onchain/src/LiquidityManager.sol | 2 +- onchain/src/abstracts/ThreePositionStrategy.sol | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/onchain/src/LiquidityManager.sol b/onchain/src/LiquidityManager.sol index bd5a770..656706f 100644 --- a/onchain/src/LiquidityManager.sol +++ b/onchain/src/LiquidityManager.sol @@ -200,7 +200,7 @@ contract LiquidityManager is ThreePositionStrategy, PriceOracle { // Record price from anchor position for VWAP if (i == uint256(Stage.ANCHOR)) { - int24 tick = position.tickLower + (position.tickUpper - position.tickLower / 2); + int24 tick = position.tickLower + ((position.tickUpper - position.tickLower) / 2); currentPrice = _priceAtTick(token0isWeth ? -1 * tick : tick); } } diff --git a/onchain/src/abstracts/ThreePositionStrategy.sol b/onchain/src/abstracts/ThreePositionStrategy.sol index 75efcf0..148f109 100644 --- a/onchain/src/abstracts/ThreePositionStrategy.sol +++ b/onchain/src/abstracts/ThreePositionStrategy.sol @@ -164,9 +164,9 @@ abstract contract ThreePositionStrategy is UniswapMath, VWAPTracker { // Calculate discoveryAmount for floor position calculation if (token0isWeth) { - discoveryAmount = LiquidityAmounts.getAmount0ForLiquidity(sqrtRatioAX96, sqrtRatioBX96, liquidity); - } else { discoveryAmount = LiquidityAmounts.getAmount1ForLiquidity(sqrtRatioAX96, sqrtRatioBX96, liquidity); + } else { + discoveryAmount = LiquidityAmounts.getAmount0ForLiquidity(sqrtRatioAX96, sqrtRatioBX96, liquidity); } _mintPosition(Stage.DISCOVERY, tickLower, tickUpper, liquidity); @@ -201,6 +201,7 @@ abstract contract ThreePositionStrategy is UniswapMath, VWAPTracker { uint256 ethBalance = _getEthBalance(); int24 vwapTick; + if (vwapX96 > 0) { // vwapX96 is priceĀ² in X96 format, need to convert to regular price // price = sqrt(priceĀ²) = sqrt(vwapX96) * 2^48 / 2^96 = sqrt(vwapX96) / 2^48