johba/harb
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

fix: evaluator: add sellKrk browser helper (uses sell widget from #456) (#461)

Browse source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
openhands 2026-03-05 13:13:04 +00:00
parent 3a3a7844ed
commit 61a9fd7e58
1 changed files with 80 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

81
scripts/harb-evaluator/helpers/swap.ts
View file

@ -1,7 +1,8 @@
/**
* Shared swap helpers for holdout scenarios.
*
* buyKrk — drives the real get-krk page swap widget (UI path, requires #393 fix).
* buyKrk — drives the real get-krk page swap widget (UI path, requires #393 fix).
* sellKrk — drives the get-krk page sell widget UI (requires #456 sell tab).
* sellAllKrk — submits approve + exactInputSingle directly via window.ethereum
* (no UI widget — the Uniswap router handles the on-chain leg).
*/
@ -167,6 +168,84 @@ export async function buyKrk(page: Page, ethAmount: string, opts?: BuyKrkOptions
await page.screenshot({ path: `test-results/${screenshotPrefix}-after-buy.png` });
}
/**
* Navigate to the get-krk page, switch to Sell tab, fill KRK amount, click Sell.
* Wallet must already be connected.
*
* Drives the real sell widget UI (requires the #456 sell tab).
*
* If config is provided, queries WETH balance before and after the sell and
* returns the delta. Otherwise returns 0n (caller is responsible for verification).
*
* @param page - Playwright page with injected wallet
* @param amount - KRK amount to sell (as string). Use 'max' to click the Max button.
* @param screenshotPrefix - Optional prefix for screenshot filenames
* @param config - Optional config to query WETH received after sell
* @returns WETH received (balance diff) or 0n if config is not provided
*/
export async function sellKrk(
page: Page,
amount: string,
screenshotPrefix?: string,
config?: SellConfig,
): Promise<bigint> {
console.log(`[swap] Selling ${amount} KRK via get-krk page sell widget...`);
await navigateSPA(page, '/app/get-krk');
const sellTab = page.getByTestId('swap-mode-sell');
await expect(sellTab).toBeVisible({ timeout: 10_000 });
await sellTab.click();
if (amount === 'max') {
const maxButton = page.locator('.max-button');
await expect(maxButton).toBeVisible({ timeout: 5_000 });
await maxButton.click();
console.log('[swap] Clicked Max button');
} else {
const sellInput = page.getByTestId('swap-sell-amount-input');
await expect(sellInput).toBeVisible({ timeout: 5_000 });
await sellInput.fill(amount);
console.log(`[swap] Filled sell amount: ${amount}`);
}
const wethBefore = config ? await erc20BalanceOf(config.rpcUrl, WETH, config.accountAddress) : 0n;
if (screenshotPrefix) {
await page.screenshot({ path: `test-results/${screenshotPrefix}-before-sell.png` });
}
const sellButton = page.getByTestId('swap-sell-button');
await expect(sellButton).toBeVisible({ timeout: 5_000 });
console.log('[swap] Clicking Sell KRK...');
await sellButton.click();
// Button cycles: "Sell KRK" → "Approving…" / "Selling…" → "Sell KRK"
try {
await sellButton.filter({ hasText: /Approving…|Selling…/i }).waitFor({ state: 'visible', timeout: 5_000 });
console.log('[swap] Sell in progress...');
} catch {
// Sell completed before the transient state could be observed
console.log('[swap] Button state not observed (sell may have completed instantly)');
}
await expect(sellButton).toHaveText('Sell KRK', { timeout: 60_000 });
console.log('[swap] Sell completed');
if (screenshotPrefix) {
await page.screenshot({ path: `test-results/${screenshotPrefix}-after-sell.png` });
}
if (!config) return 0n;
const wethAfter = await erc20BalanceOf(config.rpcUrl, WETH, config.accountAddress);
const wethReceived = wethAfter - wethBefore;
if (wethReceived <= 0n) {
console.warn('[swap] WARNING: WETH balance did not increase after sell — pool may have returned 0 output');
} else {
console.log(`[swap] Received ${wethReceived} WETH`);
}
return wethReceived;
}
/**
* Query the current KRK balance, then approve the Uniswap router and swap
* all KRK back to WETH via on-chain transactions submitted through the