fix: address review — fix race condition and dependency graph

- contracts-local-fork and node-quality now depend on foundry-suite
  (not just bootstrap-deps) to avoid concurrent writes to onchain/out/
  and onchain/cache/ from parallel forge invocations
- Remove duplicate forge build from node-quality (artifacts already
  exist from foundry-suite)
- evolution-tests changed to depends_on: [] — it only runs npm install
  in tools/ dirs, no submodule dependency
- Remove vestigial PATH=/root/.foundry/bin export from transpiler-tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
openhands 2026-03-20 13:27:04 +00:00
parent d69310e5ff
commit 30cdd95ba0

View file

@ -50,7 +50,7 @@ steps:
'
- name: contracts-local-fork
depends_on: [bootstrap-deps]
depends_on: [foundry-suite]
image: registry.niovi.voyage/harb/node-ci:latest
environment:
HARB_ENV: BASE_SEPOLIA_LOCAL_FORK
@ -78,7 +78,6 @@ steps:
- |
bash -c '
set -euo pipefail
export PATH=/root/.foundry/bin:$PATH
cd tools/push3-transpiler
npm install --silent
npm run build
@ -86,7 +85,7 @@ steps:
'
- name: evolution-tests
depends_on: [bootstrap-deps]
depends_on: []
image: registry.niovi.voyage/harb/node-ci:latest
when:
- event: pull_request
@ -154,7 +153,7 @@ steps:
'
- name: node-quality
depends_on: [bootstrap-deps]
depends_on: [foundry-suite]
image: registry.niovi.voyage/harb/node-ci:latest
environment:
CI: "true"
@ -165,9 +164,6 @@ steps:
set -euo pipefail
npm config set fund false
npm config set audit false
# kraiken-lib imports ABIs from onchain/out/ — build contracts first
export PATH=/root/.foundry/bin:$PATH
(cd onchain && forge build)
./scripts/build-kraiken-lib.sh
# Root install links workspace packages (@harb/web3) + all workspace members
npm install --no-audit --no-fund