fix: Add architectural lint rules with agent-friendly error messages (#232)

- landing/eslint.config.js: ban imports from web-app paths (rule 1),
  direct RPC clients from viem/@wagmi/vue (rule 2), and axios (rule 4)
- web-app/eslint.config.js: ban string interpolation inside GraphQL
  query/mutation property values (rule 3); fixes 4 pre-existing violations
  in usePositionDashboard, usePositions, useSnatchNotifications,
  useWalletDashboard by migrating to variables: {} pattern
- services/ponder/eslint.config.js: ban findMany() calls that lack a
  limit parameter to prevent unbounded indexed-data growth (rule 5)

All error messages follow the [what is wrong][rule][how to fix][where to
read more] template so agents and humans fix on the first try.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
openhands 2026-02-24 20:44:17 +00:00
parent e3d45bb8ef
commit 0d761744df
7 changed files with 95 additions and 13 deletions

View file

@ -72,5 +72,18 @@ export default [
'max-statements': 'off',
},
},
{
name: 'arch/ponder-bounded-queries',
rules: {
'no-restricted-syntax': [
'error',
{
selector: "CallExpression[callee.property.name='findMany']:not(:has(Property[key.name='limit']))",
message:
"Ponder findMany() called without a limit parameter. Unbounded queries will grow without limit as the chain is indexed — never use findMany() without a limit. Always specify `limit` in the options object. Use the ring buffer pattern from docs/ARCHITECTURE.md.",
},
],
},
},
eslintConfigPrettier,
];