harb/onchain/src/IOptimizer.sol

// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity ^0.8.19;

/**
 * @notice Dyadic rational input: mantissa × 2^(-shift).
 *         For shift == 0 (current usage via _toDyadic), value == mantissa.
 */
struct OptimizerInput {
    int256 mantissa;
    int256 shift;
}
-												fix: PR #551 review findings - OptimizerV3Push3.sol + Optimizer.sol

Critical bugs fixed:
- OptimizerV3Push3: Add input validation for mantissa (inputs[0].mantissa <= 1e18)
- OptimizerInput struct: Move to shared IOptimizer.sol to eliminate duplication
- Update imports in Optimizer.sol, OptimizerV3Push3.sol, and test file

Warnings addressed:
- Document unused variables (_d2-_d7) with comments in OptimizerV3Push3
- Add shift validation: require(inputs[k].shift == 0, "shift not yet supported")
- Fix recordRecenter error style: use UnauthorizedAccount custom error

Tests: All 32 Optimizer + OptimizerV3Push3 tests passing

											
										
										
											2026-03-10 23:13:57 +00:00
+								// SPDX-License-Identifier: GPL-3.0-or-later
 								pragma solidity ^0.8.19;
 								/**
 								 * @notice Dyadic rational input: mantissa × 2^(-shift).
 								 *         For shift == 0 (current usage via _toDyadic), value == mantissa.
 								 */
 								struct OptimizerInput {
 								    int256 mantissa;
 								    int256 shift;
 								}